fix(direct-access): save context not present if direct access enabled #6764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Open discussion](#6459) for feature with other issues
Codecov Report
@@ Coverage Diff @@
## master #6764 +/- ##
==========================================
- Coverage 93.90% 93.32% -0.59%
==========================================
Files 169 169
Lines 12197 12197
==========================================
- Hits 11454 11383 -71
- Misses 743 814 +71
Continue to review full report at Codecov.
|
|
Can you add a test case? Looks good! |
3 tasks
|
@omairvaiyani I'm going to add a test case to cover direct access. This has already been fixed via |
dplewis
approved these changes
Jul 17, 2020
|
@dplewis thanks for that! My apologies for the uncertainty around the fix. We've been settled on parse-server v3~ since the GraphQL Relay change so my patches are hazy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR introduced a new feature but does not work with experimental Direct Access which uses
ParseServerRESTController.Proposed change just adds
contextintodataas expected byRestWriteOpen discussion for feature with other issues